Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap with Yarn #2673

Merged
merged 6 commits into from
Jun 29, 2017
Merged

Bootstrap with Yarn #2673

merged 6 commits into from
Jun 29, 2017

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Jun 28, 2017

lerna bootstrap uses npm unless otherwise specified.
It also doesn't understand when it should or should not apply concurrency.

This PR polishes contributor workflow and addresses above issues (long time nit I've had but too lazy to do anything about).

@Timer Timer added this to the 1.0.9 milestone Jun 29, 2017
@Timer Timer merged commit aad5987 into facebook:master Jun 29, 2017
@Timer Timer deleted the bootstrap-yarn branch June 29, 2017 04:45
zangrafx added a commit to absolvent/create-react-app that referenced this pull request Jun 29, 2017
@zangrafx
Merge remote-tracking branch 'upstream/master'
1368b90 
* upstream/master: (55 commits)
  Fix minor typo (facebook#2679)
  Bootstrap with Yarn when available (facebook#2673)
  Add more info about apache client side routing (facebook#2666)
  Test Node 8 on Travis (facebook#2659)
  Add json and css to lint-staged in template README (facebook#2671)
  Add a note about fixed vulnerability in 1.0.8
  Publish
  Changelog for 1.0.8 (facebook#2664)
  Reformat source code with Prettier 1.5.2
  Update Prettier to v1 (facebook#2465)
  Update ISSUE_TEMPLATE.md
  Local testing docker links (facebook#2662)
  Better React Native Web support (facebook#2511)
  Bump dependencies (facebook#2658)
  Minor code style edits to user guide (facebook#2660)
  Don't ask to install webpack for using Styleguidist (facebook#2656)
  Put react-scripts in dependencies, not devDependencies (facebook#2657)
  Razzle added to the alternatives (facebook#2517)
  Warn about large bundle sizes (facebook#2648)
  Add instructions to use source-map-explorer (facebook#1641)
  ...

# Conflicts:
#	packages/react-dev-utils/package.json
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json
@gaearon gaearon mentioned this pull request Jun 29, 2017
Merged
@gaearon
Copy link
Contributor

gaearon commented Jun 29, 2017

I got these after running npm install in the root.
Is it expected?
screen shot 2017-06-29 at 13 10 47

@Timer
Copy link
Contributor Author

Timer commented Jun 29, 2017

Yeah, it uses Yarn in all subdirectories instead of npm.
What's more odd to me is that you only have 3 and not one for every package. 🤔

If you run lerna clean then yarn do they all become present?

Maybe we should remove the lock files post bootstrap.

@gaearon
Copy link
Contributor

gaearon commented Jun 29, 2017

I think we can just run yarn install --no-lockfile?

@Timer
Copy link
Contributor Author

Timer commented Jun 29, 2017

Perhaps, but we'll have to make sure lerna works with that.
I dunno what'll happen if a flag is passed in.

@Timer
Copy link
Contributor Author

Timer commented Jun 29, 2017 •
edited
Loading

Looks like Lerna checks if the package manager needs to be ran before executing yarn or npm, thus why you only got 3 lock files (by it manually looking through dependencies).

Unfortunately, Lerna does not support passing a flag to the npm client.
I can open a PR there if that's something we'd like to do, otherwise we can just remove the lock files post-bootstrap. Looks like there's already a PR, see below linked issue.

@Timer Timer mentioned this pull request Jun 29, 2017
Merged
9 tasks
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
@Timer @romaindso
Bootstrap with Yarn when available (facebook#2673)
bb3a9e5 
* Bootstrap with Yarn if we can

* Update test scripts

* Check OS and npm concurrency ability

* Windows support

* Update bootstrap.js

* Install yarn before bootstrap
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@Timer @wmonk
Bootstrap with Yarn when available (#2673)
03a52d4 
* Bootstrap with Yarn if we can

* Update test scripts

* Check OS and npm concurrency ability

* Windows support

* Update bootstrap.js

* Install yarn before bootstrap
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
@Timer @morgs32
Bootstrap with Yarn when available (facebook#2673)
f72bffa 
* Bootstrap with Yarn if we can

* Update test scripts

* Check OS and npm concurrency ability

* Windows support

* Update bootstrap.js

* Install yarn before bootstrap
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
1.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @gaearon @facebook-github-bot